ft2font: Make glyph loading failures more robust - #32226
Open
QuLogic wants to merge 1 commit into
Open
Conversation
iccir
reviewed
Aug 21, 2026
| bool fallback = true; | ||
| FT2Font *ft_object = nullptr; | ||
|
|
||
| self->load_char(charcode, static_cast<FT_Int32>(flags), ft_object, fallback); |
Contributor
There was a problem hiding this comment.
I'm worried about a future change to load_char() failing to fill ft_object. A subsequent call to PyGlyph_from_FT2Font() will crash due to the nullptr dereference.
From a C/Obj-C background, I'd like to see an explicit check against nullptr after this call and an exception thrown if nullptr. However, I'm not sure if that matches our C++.
The PR addresses the original bug; however, and I'm fine with approving it as-is.
Member
Author
There was a problem hiding this comment.
That's also a pretty reasonable thing to check.
The main fix is to `FT2Font::load_char`, which didn't correctly fail if no fallback was defined to catch missing glyphs. Also, while `PyGlyph_from_FT2Font` is internal and should never be called before loading a glyph, add a check in there anyway, just to be safe.
QuLogic
force-pushed
the
ft2font-load-failure
branch
from
August 21, 2026 03:43
291e0ec to
6adedac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
The main fix is to
FT2Font::load_char, which didn't correctly fail if no fallback was defined to catch missing glyphs.Also, while
PyGlyph_from_FT2Fontis internal and should never be called before loading a glyph, add a check in there anyway, just to be safe.Fixes #32224
AI Disclosure
None
PR quality check