Fix the rounding of animation frame size to match the eventual canvas size - #32194
Open
ayshih wants to merge 1 commit into
Open
Fix the rounding of animation frame size to match the eventual canvas size#32194ayshih wants to merge 1 commit into
ayshih wants to merge 1 commit into
Conversation
QuLogic
reviewed
Aug 10, 2026
| ho /= self.dpi | ||
| if self.codec == 'h264': | ||
| wo, ho = self.fig.get_size_inches() | ||
| w, h = adjusted_figsize(wo, ho, self.dpi, 2) |
Member
There was a problem hiding this comment.
What about the calculation in adjusted_figsize?
Contributor
Author
There was a problem hiding this comment.
I think the calculation in adjusted_figsize() is "fine" to stay as-is given how it uses np.nextafter()
ayshih
force-pushed
the
animation_canvas_size
branch
2 times, most recently
from
August 14, 2026 20:21
5ec6ef1 to
8d07fc0
Compare
ayshih
force-pushed
the
animation_canvas_size
branch
from
August 17, 2026 13:28
8d07fc0 to
dcc9091
Compare
Contributor
Author
|
With apologies to @fudianchn, the first code change in this PR ended up being the same as in the now-closed #32189. Despite what I wrote in #32189 (comment), it turns out that we cannot simply query the canvas size of the existing figure because the animation may end up saving the figure using a different DPI – either implicitly or explicitly set – than the existing figure's DPI. There are contortions that could be considered, but I think at that point it's better to simply repeat the same rounding tolerance. |
ayshih
marked this pull request as ready for review
August 17, 2026 17:25
QuLogic
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
As reported in #32186, the change in #32038 to have appropriately rounded canvas sizes made the necessary updates to the backends, but missed that
matplotlib.animationalso needed to be updated. This PR updatesmatplotlib.animationto calculate the frame size with the same rounding as will be used for the canvas size during saving.Closes #32186
AI Disclosure
No AI was used
PR quality check