Skip to content

Support 3D Piece Sets #3467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jordansprojects wants to merge 6 commits into
base: main
Choose a base branch
from
+132 −15
Draft

Support 3D Piece Sets #3467

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8f5b6ec
begin to create tab view to differentiate between 2d and 3d pieces
jordansprojects Jul 11, 2026
0f65fa5
possible approach to supporting 3d pieces, starting with logic in pie…
jordansprojects Jul 20, 2026
a323b23
temp fix to merge conflict
jordansprojects Jul 25, 2026
913f174
merge in latest changes, continue to edit settings screens
jordansprojects Jul 25, 2026
ac1db65
add logic in board_preferences to sub in 3d piece assets when pieceSe…
jordansprojects Jul 29, 2026
f633ef5
recombine pieces, use board settings and preferences to indicate whet…
jordansprojects Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
merge in latest changes, continue to edit settings screens
  • Loading branch information
@jordansprojects
jordansprojects committed Jul 25, 2026
commit 913f17422c147d99d600e280990b143e9d320c57
2 changes: 1 addition & 1 deletion lib/src/view/settings/board_settings_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class _BoardSettingsScreenState extends ConsumerState<BoardSettingsScreen> {
),
SettingsListTile(
settingsLabel: Text(context.l10n.pieceSet),
settingsValue: boardPrefs.pieceSet.label,
settingsValue: boardPrefs.pieceSet3D?.label ?? boardPrefs.pieceSet.label,
onTap: () {
Navigator.of(context).push(PieceSetScreen.buildRoute());
},
Expand Down
81 changes: 41 additions & 40 deletions lib/src/view/settings/piece_set_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ void remove3DPieceSetFromPreferences(){

return DefaultTabController(
length: 2,
child: Scaffold(
appBar: AppBar(
child: PlatformScaffold(
appBar: PlatformAppBar(
title: Text(context.l10n.pieceSet),
actions: [if (isLoading) const PlatformAppBarLoadingIndicator()],
bottom: const TabBar(
Expand All @@ -109,6 +109,44 @@ void remove3DPieceSetFromPreferences(){
),
body: TabBarView(
children: [
Center(
child: SafeArea(
child: ListView.separated(
itemCount: PieceSet.values.length,
separatorBuilder: (_, _) => Theme.of(context).platform == TargetPlatform.iOS
? const PlatformDivider()
: const SizedBox.shrink(),
itemBuilder: (context, index) {
final pieceSet = PieceSet.values[index];
return ListTile(
trailing: boardPrefs.pieceSet == pieceSet && boardPrefs.pieceSet3D == null ? const Icon(Icons.check) : null,
title: Text(pieceSet.label),
subtitle: ConstrainedBox(
constraints: const BoxConstraints(maxWidth: 264),
child: Stack(
children: [
BrightnessHueFilter(
brightness: boardPrefs.brightness,
hue: boardPrefs.hue,
child: boardPrefs.boardTheme.thumbnail,
),
Row(
children: [
for (final img in getPieceImages(pieceSet)) Image(image: img, height: 44),
],
),
],

),
),
onTap: isLoading ? null : () => onChanged(pieceSet),
selected: boardPrefs.pieceSet == pieceSet,
);
},
),
),
),

Center(
child: SafeArea(
child: ListView.separated(
Expand Down Expand Up @@ -149,44 +187,7 @@ void remove3DPieceSetFromPreferences(){
},
),
),
),
Center(
child: SafeArea(
child: ListView.separated(
itemCount: PieceSet.values.length,
separatorBuilder: (_, _) => Theme.of(context).platform == TargetPlatform.iOS
? const PlatformDivider()
: const SizedBox.shrink(),
itemBuilder: (context, index) {
final pieceSet = PieceSet.values[index];
return ListTile(
trailing: boardPrefs.pieceSet == pieceSet ? const Icon(Icons.check) : null,
title: Text(pieceSet.label),
subtitle: ConstrainedBox(
constraints: const BoxConstraints(maxWidth: 264),
child: Stack(
children: [
BrightnessHueFilter(
brightness: boardPrefs.brightness,
hue: boardPrefs.hue,
child: boardPrefs.boardTheme.thumbnail,
),
Row(
children: [
for (final img in getPieceImages(pieceSet)) Image(image: img, height: 44),
],
),
],

),
),
onTap: isLoading ? null : () => onChanged(pieceSet),
selected: boardPrefs.pieceSet == pieceSet,
);
},
),
),
),
)
],
),
),
Expand Down
Loading