You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the entire sidebar is blurred even when nothing is there, which detracts from the background image feature
This change moves the transparency blur to the components of the sidebar rather than the entire sidebar itself. The components I added to were based on the classes in the div in home.scala
The css divs don't seem to be used outside of this lobby sidebar so adding the mixin to the child component css shouldn't affect anything other than the lobby sidebar
The .lobby__side wrapper in _lobby.scss still has @include backdrop-blur-if-transparent on it (line 41), so it still blurs unconditionally regardless of content. The screenshot above is a logged-out view, where .about-side always renders with content, so that state can't actually hit the empty-sidebar bug from #20953. The bug reproduces for a logged-in user with no streams, spotlights, classes, or timeline entries. In that case .lobby__side would still show the blur even after this change. Removing the mixin from the wrapper (keeping it only on the child components) would complete the fix.
I agree this is better visually. Here is the current state for comparison:
PS: it seems Firefox's built-in screenshot tool unblurs the sidebar, so I had to take this screenshot using my OS's screenshot tool (Spectacle). Strange effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Related Issue
Addresses issue 20953
This is my first contribution to Lichess, if I missed anything about the contribution process or got something wrong please let me know
Tested running lila-docker locally, screenshot below
