ui: improve alignment of user activity timeline entries - #19386
Merged
Conversation
Collaborator
|
nice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Spotted that user activity timeline have some unven alignment and take a lot of vertical spaces in some case.
Screenshots
How
Refactor user activity timeline to flex layout, reorder score nodes at the end, align 1 and 2 lines content with the icon (with more lines icon will stay at the top entry, aligned with two first lines), reduce vertical spacing.
I'm happy to work on the changes further if you have any requests or tips how to improve refreshed appearance.
Important
This changeset might need a bit of testing on more complex data, and with some rarer entries, since locally seeded data are quite simple. I have moved manually few entries from PROD for testing but definitely missed some cases.
Preview