Add piece maneuver arrows for top engine line - #19218
Merged
Merged
Conversation
Collaborator
|
That's really nice, and I agree that it can be enabled by default. Not sure we even need a setting to disable it. It would be better if we could do without it. |
Contributor
Author
|
Sure, I just wanted to give people the choice just in case they don't like it 😅 |
we'll decide whether to add it based on the scream-o-meter method
|
I don't think this is a great update unfortunately, the second arrow is really dependent on what move the opp plays in response to the first arrow move, there is no guarantee the best move will be played or was played in the game being analysed so the second arrow is presumptive and confusing, and often not even the best move after the engine thinks about it some more. I thought my UI was glitching until I saw this is deliberate. Please reconsider, thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds multiple arrows if the engine suggests the same piece should be moved multiple consecutive times, indicating a maneuver.
Up to 3 arrows for piece maneuvers and a setting to disable it.
interferingArrowavoids clutter.Closes #10982