Backport 26.1: validate circular default values - #4450
Open
andimarek wants to merge 1 commit into
Open
Conversation
* init * improve spec alignment * Avoid unnecessary circular default validation work --------- Co-authored-by: Andreas Marek <andimarek@fastmail.fm>
Contributor
Test ReportTest Results
Code Coverage (Java 25)
Changed Class Coverage (34 classes)
Directive — method details
DirectiveDefinition — method details
DirectiveLocation — method details
FragmentSpread — method details
FragmentSpread.Builder — method details
PrettyAstPrinter — method details
VariableDefinition — method details
VariableDefinition.Builder — method details
EditOperationAnalyzer — method details
GraphQLDirective — method details
GraphqlDirectivesContainerTypeBuilder — method details
GraphQLInterfaceType.Builder — method details
GraphQLObjectType — method details
SchemaProblem — method details
TypeDefinitionRegistry — method details
UnionTypesChecker — method details
NoUnbrokenInputCycles — method details
OperationValidator — method details
ValidationContext — method details
ValidationError.Builder — method details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4253 to the
26.xmaintenance branch.Input object fields can define default values in ways that form cycles. For example in this schema:
types A and B form a cycle with their default values, such that the coerced default value of
A.bis an infinitely nested ObjectValue like{a: {b: {a: {...}}}Today, this sdl can be parsed into a GraphQLSchema object, though a StackOverflow will be thrown during execution if the system encounters a value for one of these types.
The spec added an InputObjectDefaultValueHasCycle algorithm to handle this case. This PR implements this algorithm as a
NoDefaultValueCircularRefsvalidator which allows these cyclic schemas to be rejected during validation.This behavior matches graphql-js v17, which added a similar validation in this pr