Skip to content

feat(operator): Add tolerations and nodeSelector to the FeatureStore CR - #6741

Merged
ntkathole merged 2 commits into
feast-dev:masterfrom
ShumzZzZz:feat_operator_add_toleration_nodeselector_to_featurestore_cr
Aug 21, 2026
Merged

feat(operator): Add tolerations and nodeSelector to the FeatureStore CR#6741
ntkathole merged 2 commits into
feast-dev:masterfrom
ShumzZzZz:feat_operator_add_toleration_nodeselector_to_featurestore_cr

Conversation

@ShumzZzZz

@ShumzZzZz ShumzZzZz commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Adds optional pod-level scheduling knobs to the FeatureStore CR so users can place the operator-managed Deployment on specific nodes or on nodes with taints:

spec:
  services:
    nodeSelector:
      kubernetes.io/os: linux
    tolerations:
      - key: dedicated
        operator: Equal
        value: feast
        effect: NoSchedule

Both fields live on spec.services, alongside the existing affinity and topologySpreadConstraints. tolerations is applied directly to the pod spec. nodeSelector becomes the base selector, with the pre-existing per-server containerConfigs.nodeSelector overlaid on top (per-service wins on key conflicts), preserving the existing merge-with-mutating-webhook behavior.

Regenerated artifacts: deepcopy, CRD bases, dist/install.yaml, the API reference, and the OLM bundle.

Which issue(s) this PR fixes

N/A

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Testing: added unit coverage for top-level nodeSelector, per-service override precedence, and tolerations. go build ./..., go vet ./..., and all non-e2e operator test packages pass.

@ShumzZzZz
ShumzZzZz requested a review from a team as a code owner August 14, 2026 23:03
@codecov-commenter

codecov-commenter commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.95%. Comparing base (1d5be95) to head (847e11b).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6741   +/-   ##
=======================================
  Coverage   46.95%   46.95%           
=======================================
  Files         419      419           
  Lines       51839    51839           
  Branches     7515     7515           
=======================================
  Hits        24339    24339           
  Misses      25766    25766           
  Partials     1734     1734
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 48.24% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d5be95...847e11b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

HaoXuAI
HaoXuAI requested changes Aug 16, 2026
View reviewed changes

@HaoXuAI HaoXuAI left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Tolerations and NodeSelector to api/v1alpha1/featurestore_types.go, regenerate its deepcopy code and both CRD schemas, and add coverage for the served legacy version. v1alpha1 is still served by the CRD, so users submitting that API version currently cannot configure these fields. Similar cross-version CRD changes in this repository update both API packages.

@ShumzZzZz
ShumzZzZz force-pushed the feat_operator_add_toleration_nodeselector_to_featurestore_cr branch 2 times, most recently from 15a5334 to 2d150da Compare August 17, 2026 18:16
@ShumzZzZz
ShumzZzZz requested a review from HaoXuAI August 17, 2026 19:11
@ShumzZzZz

ShumzZzZz commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

@HaoXuAI thanks for the review, I've made the request change, please take another look when available; also failed test seems to be related to GitHub degredation, not the change:

Update - The degradation affecting API Requests, Actions, Git Operations, Issues, Pages, Pull Requests and Webhooks has been mitigated. We are monitoring to ensure stability.
Aug 17, 2026 - 16:59 UTC

@ShumzZzZz
ShumzZzZz force-pushed the feat_operator_add_toleration_nodeselector_to_featurestore_cr branch from 2d150da to 0f4800d Compare August 20, 2026 15:24
ntkathole
ntkathole approved these changes Aug 21, 2026
View reviewed changes

@ntkathole ntkathole left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ntkathole

ntkathole commented Aug 21, 2026

Copy link
Copy Markdown
Member

@ShumzZzZz can you also please update the documentation specially https://docs.feast.dev/master/how-to-guides/feast-on-kubernetes/feast-operator

@ShumzZzZz
feat(operator): Add tolerations and nodeSelector to the FeatureStore CR
6d92d3f 
Allow scheduling the operator-managed Deployment on tainted or specific nodes via spec.services.tolerations and spec.services.nodeSelector, alongside the existing affinity and topologySpreadConstraints fields.

Signed-off-by: Shumin <shumin.zheng@outlook.com>
@ShumzZzZz
ShumzZzZz force-pushed the feat_operator_add_toleration_nodeselector_to_featurestore_cr branch from 0f4800d to 6d92d3f Compare August 21, 2026 04:11
@ShumzZzZz

ShumzZzZz commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

@ntkathole thanks for the review and I have just updated the operator configuration guide

@ntkathole
ntkathole merged commit 03dac6f into feast-dev:master Aug 21, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntkathole ntkathole ntkathole approved these changes
@HaoXuAI HaoXuAI Awaiting requested review from HaoXuAI

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ShumzZzZz @codecov-commenter @ntkathole @HaoXuAI