FIX: Bulk tag, category, and read-state ops no longer lie or overreach - #42784
Open
ZogStriP wants to merge 1 commit into
Open
FIX: Bulk tag, category, and read-state ops no longer lie or overreach#42784ZogStriP wants to merge 1 commit into
ZogStriP wants to merge 1 commit into
Conversation
ZogStriP
force-pushed
the
fix-bulk-actions-silent-noops
branch
from
August 21, 2026 08:47
96eb0fb to
52cd759
Compare
ZogStriP
force-pushed
the
fix-bulk-actions-silent-noops
branch
from
August 21, 2026 08:52
52cd759 to
1aa8bdc
Compare
`PostRevisor` silently refuses tag and category changes the user lacks permission for, yet the bulk layer gated only on `can_edit?` and counted every topic as changed: a green "Completed" toast, zero changes applied, and each refused revise still bumped `post.version` and wrote an empty `PostRevision`, permanently stamping a bogus "1 edit" indicator on up to 1000 topics per click. The UI also offered "Manage tags" to users the server would then refuse. `reset_bump_dates` checked permissions once, globally, so a TL4 user could reset bump dates on topics in restricted categories they cannot see — the single-topic route fixed this exact hole in aac9494, but the bulk path was missed. `destroy_post_timing` had no permission check at all, and could drive `posts.reads` negative on topics where the caller had no timings to destroy.
ZogStriP
force-pushed
the
fix-bulk-actions-silent-noops
branch
from
August 21, 2026 08:54
1aa8bdc to
4da1a05
Compare
pmusaraj
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #42776. Follow-up 2 of 2 from the bulk-actions investigation (meta t/410444).
PostRevisorsilently refuses tag and category changes the user lacks permission for, yet the bulk layer gated only oncan_edit?and counted every topic as changed: a green "Completed" toast, zero changes applied — and each refused revise still bumpedpost.versionand wrote an emptyPostRevision, permanently stamping a bogus "1 edit" indicator on up to 1000 topics per click. The UI also offered "Manage tags" to users the server would then refuse.reset_bump_dateschecked permissions once, globally, so a TL4 user could reset bump dates on topics in restricted categories they cannot see — the single-topic route fixed this exact hole in aac9494 (#37798), but the bulk path was missed.destroy_post_timinghad no permission check at all, and could driveposts.readsnegative on topics where the caller had no timings to destroy.