fix(i18n): register missing Ukrainian locale files (contentTemplates, yearInReview) - #15506
fix(i18n): register missing Ukrainian locale files (contentTemplates, yearInReview)#15506AndriyRyabchenko wants to merge 2 commits into
Conversation
The Ukrainian locale index does not import contentTemplates.json, snooze.json and yearInReview.json, so their already-translated strings fall back to English in the dashboard. Add the missing imports and spreads.
|
An admin can assign one in Ito team settings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f1aead00d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ...settings, | ||
| ...signup, | ||
| ...sla, | ||
| ...snooze, |
There was a problem hiding this comment.
For users whose resolved locale is Ukrainian, spreading this bundle activates incorrect parser tokens already present in uk/snooze.json: WEEK is день, MONTH is тиждень, and YEAR is місяць. buildReplacementPairsUncached converts those localized values according to their keys, so entering 1 тиждень is parsed as one month and 1 місяць as one year, silently snoozing the conversation until the wrong date. Correct these translations through the project's translation workflow before exposing this bundle, or leave it unregistered until they are corrected.
AGENTS.md reference: AGENTS.md:L88-L90
Useful? React with 👍 / 👎.
Drop snooze from this change: uk/snooze.json has swapped SNOOZE_PARSER unit tokens (WEEK=день, MONTH=тиждень, YEAR=місяць) that would make the snooze parser misread input. Leave snooze unregistered until fixed via Crowdin.
|
Good catch on the snooze parser — confirmed. I've dropped |
Summary
app/javascript/dashboard/i18n/locale/uk/index.jsdoes not import two locale files that exist and are already translated into Ukrainian, so their strings fall back to English in the dashboard:contentTemplates.jsonyearInReview.jsonChanges
Add the two missing
importstatements and their spreads, in alphabetical order to match the existing convention. No string content is changed (handled via Crowdin).Note on snooze
snooze.jsonis also unregistered foruk, but it is intentionally left out of this PR: itsSNOOZE_PARSER.UNITSare mistranslated (WEEK→день,MONTH→тиждень,YEAR→місяць, plus untranslated plurals). Registering it as-is would make the snooze parser misread typed input. It should be corrected via Crowdin first, then registered separately. Thanks to the automated review for catching this.