Allow the usage of abstract parent classes in Models - #31
Merged
Conversation
x7airworker
requested review from
JanHolger,
JulianFun123 and
TimothyGillespie
November 29, 2021 14:59
TimothyGillespie
suggested changes
Nov 29, 2021
TimothyGillespie
previously approved these changes
Nov 29, 2021
Contributor
|
Approved, but I just noticed I don't have any permissions to merge anymore. |
JanHolger
requested changes
Nov 30, 2021
Member
GitHub seems to only have a Member and Owner role. I didn't find any way to define more fine grained permissions and since the CI needs to have access to the sonatype credentials which are quite sensitive and could be used to upload arbitrary artifacts to our group on maven central (which can't be deleted in any way), I removed x7airworker and you from the Owner role for now. Julian still has access in case I am unavailable. |
JanHolger
approved these changes
Dec 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13
Bumped version to 1.0.3-SNAPSHOT.
Added Unit test TableInfoTest