Commit 18078bf
[scan] Fix build_for_testing failure to fail
Scan's `ErrorHandler.handle_build_error` has explicit logic that
checks for `/Executed/` pattern in logs. It seems to be meant for case
where tests will be run with same command and so we would want to wait
for test results parsing instead. But this is causing scan to not to
fail under `build_for_testing` configuration when there is such
pattern in logs (eg. some file name contains it).
In order to fix this, I propose to explicitly check for exit status
code in `build_for_testing` mode and produce an error if status is not
ok.
Fixes #206851 parent a9a7255 commit 18078bf
2 files changed
Lines changed: 38 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
264 | 264 | | |
265 | 265 | | |
266 | 266 | | |
267 | | - | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
268 | 274 | | |
269 | 275 | | |
270 | 276 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
173 | 173 | | |
174 | 174 | | |
175 | 175 | | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
176 | 207 | | |
177 | 208 | | |
178 | 209 | | |
| |||
0 commit comments